fix(engine): use correct error codes for invalid payload attributes#1383
Closed
mattsse wants to merge 1 commit into
Closed
fix(engine): use correct error codes for invalid payload attributes#1383mattsse wants to merge 1 commit into
mattsse wants to merge 1 commit into
Conversation
mattsse
force-pushed
the
fix-withdrawals-error-codes
branch
6 times, most recently
from
bbc76f9 to
3d3e507
Compare
Per the Engine API spec, error code -38003 (Invalid payload attributes) should be returned when payload attributes are invalid/inconsistent, not -32602 (Invalid params). This fixes withdrawals tests that incorrectly expected -32602 for: - Pre-Shanghai ForkchoiceUpdatedV2 with non-null withdrawals - Pre-Shanghai NewPayloadV2 with withdrawals - Post-Shanghai FCU with null withdrawals (PayloadAttributesV1) - Post-Shanghai NewPayloadV2 with null withdrawals (ExecutionPayloadV1) Spec reference: https://github.com/ethereum/execution-apis/blob/main/src/engine/common.md#errors
mattsse
force-pushed
the
fix-withdrawals-error-codes
branch
from
3d3e507 to
80a8438
Compare
Collaborator
|
Some of these cases have now been fixed in #1398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the Engine API spec, error code
-38003(Invalid payload attributes) should be returned when payload attributes are invalid/inconsistent, not-32602(Invalid params).This fixes withdrawals tests that incorrectly expected
-32602for:Spec reference: https://github.com/ethereum/execution-apis/blob/11517b401d84aee48e7f36ab366034e642a101c0/src/engine/common.md?plain=1#L99